robertlipe [Tue, 31 Dec 2013 20:04:52 +0000 (20:04 +0000)]
Leak fixes in v900
robertlipe [Tue, 31 Dec 2013 19:43:08 +0000 (19:43 +0000)]
Compile fix for Ubuntu. Fix valgrind warning from scribble code.
robertlipe [Tue, 31 Dec 2013 19:35:46 +0000 (19:35 +0000)]
BAM, NEW_STRINGS is now the default.
(Now off to deal with the inevitable leaks I just introduced...)
robertlipe [Tue, 31 Dec 2013 19:32:44 +0000 (19:32 +0000)]
Let zconf pick up our config.h. Regenerate dependencies.
robertlipe [Tue, 31 Dec 2013 19:20:31 +0000 (19:20 +0000)]
Fix zlib, warning tweaks.
robertlipe [Tue, 31 Dec 2013 16:52:55 +0000 (16:52 +0000)]
Update to zlib 1.2.8.
robertlipe [Tue, 31 Dec 2013 16:27:35 +0000 (16:27 +0000)]
Update to shapelib 1.3.0
robertlipe [Tue, 31 Dec 2013 16:24:16 +0000 (16:24 +0000)]
"fix" use after free in tef.
robertlipe [Tue, 31 Dec 2013 06:57:15 +0000 (06:57 +0000)]
Fix (well, paper over...) heap-use-after-free in psitrex.
robertlipe [Tue, 31 Dec 2013 06:35:15 +0000 (06:35 +0000)]
Introduce leaks (probably) in igc and google for now, just to get
code building and passing in NEW_STRINGS.
robertlipe [Tue, 31 Dec 2013 06:06:44 +0000 (06:06 +0000)]
Fix a test case error in gdb caused by excessive bogusness. I have No Idea
why extra_data is involved in this path.
robertlipe [Tue, 31 Dec 2013 05:02:49 +0000 (05:02 +0000)]
This is a groady submit. This is where I take all of the things that were
tacky or sleazy related to character encoding and basically apply pain killer
to them. Most of the tests were clearly made up and were just
institutionalizing what we did instead of thinking about what was right.
Remove the '-c' flag.
robertlipe [Tue, 31 Dec 2013 01:23:58 +0000 (01:23 +0000)]
A further beatdown on binary option handling in the GUI. I think it
finally works sensibly now.
robertlipe [Tue, 31 Dec 2013 01:01:14 +0000 (01:01 +0000)]
Mechanical rename of class member variables in the GUI. No real changes.
tsteven4 [Tue, 31 Dec 2013 00:42:04 +0000 (00:42 +0000)]
Ignore talker identification in nmea reader.
robertlipe [Mon, 30 Dec 2013 23:06:04 +0000 (23:06 +0000)]
Rework the way boolean options are handled in the GUI. They're now
emitted only if they're not the default.
Rename member variables to use foo_ convention.
tsteven4 [Sun, 15 Dec 2013 22:48:01 +0000 (22:48 +0000)]
fix some encoding issues with openoffice.style.
regenerate internal_styles.cc, deleteing previously deprecated styles.
tsteven4 [Sun, 15 Dec 2013 15:23:19 +0000 (15:23 +0000)]
fix declaration of phony targets.
a failure example was "make;touch gui;make gui", which would fail to execute the gui recipe.
tsteven4 [Sat, 14 Dec 2013 17:34:42 +0000 (17:34 +0000)]
fix sign issue with Qt > 5.0 in gui.
robertlipe [Sun, 1 Dec 2013 20:23:11 +0000 (20:23 +0000)]
Remove extra -I when building on Mac. No reason to search that directory
a zillion times when only one file needs mac/libusb/
robertlipe [Sun, 1 Dec 2013 20:12:46 +0000 (20:12 +0000)]
Steve teaches configure/make about Mac Qt 5.2.0s use of frameworks.
tsteven4 [Sat, 30 Nov 2013 21:14:35 +0000 (21:14 +0000)]
Quiet sed regular expression errors in dop_filter.test
robertlipe [Mon, 25 Nov 2013 03:25:28 +0000 (03:25 +0000)]
Fix most of our problems in GDB which stupidly uses Latin1 some of the
time and UTF8 some of the time.
There's still a bug in the GDB writer, I think.
robertlipe [Sun, 24 Nov 2013 04:45:44 +0000 (04:45 +0000)]
ignrando: drop straydebugging.
xmlgeneric: pass qstrings all the way through
cet_util: don't molest rte_name, rte_desc with potential double encodings.
robertlipe [Sun, 24 Nov 2013 03:58:59 +0000 (03:58 +0000)]
Fix BCR in NEW_STRINGS.
robertlipe [Sun, 24 Nov 2013 03:46:20 +0000 (03:46 +0000)]
Deprecate Kartex, a program out of business for years and whose
only appearance on our mailing list was from the contributor.
robertlipe [Sun, 24 Nov 2013 03:11:28 +0000 (03:11 +0000)]
Fix an1 for NEW_STRINGS.
robertlipe [Sun, 24 Nov 2013 02:54:38 +0000 (02:54 +0000)]
Fixes for stmwpp.cc in NEW_STRINGS.
robertlipe [Mon, 11 Nov 2013 03:46:50 +0000 (03:46 +0000)]
Another GDB checking for NEW_STRINGS. This format is still a landmine.
robertlipe [Mon, 11 Nov 2013 03:39:45 +0000 (03:39 +0000)]
Roll back swmwpp. I'm out of soul to fight with it further.
robertlipe [Mon, 11 Nov 2013 03:24:56 +0000 (03:24 +0000)]
Allow GPX reader to terminate if it detects Invalid state.
robertlipe [Mon, 11 Nov 2013 02:48:35 +0000 (02:48 +0000)]
Improvements in stmwpp for NEW_STRINGS.
robertlipe [Mon, 11 Nov 2013 02:02:32 +0000 (02:02 +0000)]
Plow through the remainder of our REALLY_MINIMAL targets with NEW_STRING.
robertlipe [Mon, 11 Nov 2013 01:05:52 +0000 (01:05 +0000)]
Bring IGC to NEW_STRINGS.
robertlipe [Sun, 10 Nov 2013 05:24:17 +0000 (05:24 +0000)]
Minimally invasive set of NEW_STRING changes for mmo.
robertlipe [Thu, 7 Nov 2013 02:59:19 +0000 (02:59 +0000)]
Beter fxi in gdb
robertlipe [Wed, 6 Nov 2013 17:09:11 +0000 (17:09 +0000)]
Leak fix in gdb.
robertlipe [Wed, 6 Nov 2013 17:06:05 +0000 (17:06 +0000)]
Leak fixes for gdb.
robertlipe [Wed, 6 Nov 2013 02:12:35 +0000 (02:12 +0000)]
Bring in NEW_STRINGS for gdb, saroute, igc, garmin, delbin, and an1.
Not because they actually work (in fact, they're all believed problematic)
but just to get them committed.
robertlipe [Wed, 23 Oct 2013 18:40:27 +0000 (18:40 +0000)]
Fix various leaks introduced in the non-NEW_STRING case when refactoring
surrounding code to be more Qt-ish.
robertlipe [Wed, 23 Oct 2013 03:37:25 +0000 (03:37 +0000)]
Rollback two formats where I introduced a regression in the non-NEW_STRINGS
case
svn merge -r4639:4637 stmwpp.cc mmo.cc
robertlipe [Wed, 23 Oct 2013 03:29:26 +0000 (03:29 +0000)]
Misc minor fixes for the !NEW_STRINGS case.
robertlipe [Wed, 23 Oct 2013 03:25:28 +0000 (03:25 +0000)]
Bring in csv_util.cc from NEW_STRING.
robertlipe [Wed, 23 Oct 2013 03:17:22 +0000 (03:17 +0000)]
Commit the (hopefully) non-contentuous NEW_STRING changes. This is the
batch that's largely mechanical and for formats, at least mostly passing
testo. It's all still disabled by default and much of it is pretty dicey,
but this patch has been growing in my tree and I wanted to get it committed.
Later, when we take out the NEW_STRING stuff, I'll refactor the stuff around
these changes which were often done to preserve fidelity to the original C
versions even when there is a better way now.
robertlipe [Wed, 23 Oct 2013 03:02:13 +0000 (03:02 +0000)]
Begin landing NEW_STRINGS work: common utilities.
robertlipe [Wed, 23 Oct 2013 01:49:39 +0000 (01:49 +0000)]
Take another run at NMN4.
robertlipe [Tue, 22 Oct 2013 02:33:15 +0000 (02:33 +0000)]
Pad internal buffer to appease -fsanitize=address. format_garmin_xt_decrypt_trk_blk is definitely going one byte too deep on that final byte and this is probably going to come back to byte me.
robertlipe [Tue, 22 Oct 2013 00:24:56 +0000 (00:24 +0000)]
Revert nmn4 change for now. I'll deal with it later.
robertlipe [Sun, 20 Oct 2013 23:31:16 +0000 (23:31 +0000)]
Make Navigon reader use QString more effectively.
robertlipe [Wed, 16 Oct 2013 18:15:48 +0000 (18:15 +0000)]
Scratch in waypoint proximity in Garmin GPX writer.
robertlipe [Sun, 6 Oct 2013 21:12:04 +0000 (21:12 +0000)]
Warning cleanpus from Conrad.
robertlipe [Thu, 3 Oct 2013 00:43:34 +0000 (00:43 +0000)]
Fix leak I introdued in new "obvious" code yesterday. Brace ourselves for
more of these soon...
robertlipe [Wed, 2 Oct 2013 04:59:49 +0000 (04:59 +0000)]
Update .pro file from Gerhard.
robertlipe [Wed, 2 Oct 2013 03:55:13 +0000 (03:55 +0000)]
Bring in some of the straight-forward pieces from NEW_STRINGS work.
robertlipe [Tue, 1 Oct 2013 04:32:48 +0000 (04:32 +0000)]
A completely mechanical search and replace to swap the first argument
for an xml_generic callback with a typdef that can be swapped at compile
time.
Yes, this is a hint of things to come to reduce future bulky merges.
robertlipe [Mon, 23 Sep 2013 02:51:49 +0000 (02:51 +0000)]
Compilation fixes.
robertlipe [Mon, 23 Sep 2013 02:45:37 +0000 (02:45 +0000)]
Land QString changes that don't require (blatant) conditional compilation
that are really mechanical.
robertlipe [Mon, 23 Sep 2013 02:40:24 +0000 (02:40 +0000)]
Make unicsv a little more QString ready internally.
robertlipe [Fri, 20 Sep 2013 20:22:32 +0000 (20:22 +0000)]
Bring forward uncontested change from NEW_STRINGS work to fix non-NEW_STRINGS build break.
robertlipe [Fri, 20 Sep 2013 05:21:25 +0000 (05:21 +0000)]
Commit the least contestable part of a CL I have in progress. Abandon the idea of a stepping stone "Strings" class. Just go straight to QString, currently behind a #define.
robertlipe [Thu, 19 Sep 2013 22:34:42 +0000 (22:34 +0000)]
Tweak testo to use more common stdout capture.
robertlipe [Thu, 19 Sep 2013 19:45:29 +0000 (19:45 +0000)]
Guilhem Bonnefile tweaks (old) Magellan Explorist PMGNCMD,END issues.
robertlipe [Wed, 18 Sep 2013 05:17:49 +0000 (05:17 +0000)]
Warning fixes from Conrad.
tsteven4 [Wed, 18 Sep 2013 00:36:46 +0000 (00:36 +0000)]
add utf-8 bom check and well-formed xml check to testo.
robertlipe [Tue, 17 Sep 2013 22:58:07 +0000 (22:58 +0000)]
Warning cleanups from Conrad.
tsteven4 [Tue, 17 Sep 2013 01:12:47 +0000 (01:12 +0000)]
change illegal xml character stripping from QRegExp/QRegularExpression to QTextCodec for efficiency. Thanks Conrad.
robertlipe [Sun, 15 Sep 2013 21:51:42 +0000 (21:51 +0000)]
Preserve note for future possibilities of strip_html.
robertlipe [Sun, 15 Sep 2013 18:44:12 +0000 (18:44 +0000)]
More pulling at removing C strings internally: unicsv_print_str and strenquote.
A victim of this is the seemingly unused sportsim format. It was doing
stupid things in the format definition with high byte characters and
unclear encodings. After a few hours trying to save it, I just chopped it.
robertlipe [Sun, 15 Sep 2013 07:18:39 +0000 (07:18 +0000)]
Replace guts of manual trimmed_strdup in tef reader. Reduce type thrash.
robertlipe [Sun, 15 Sep 2013 07:17:27 +0000 (07:17 +0000)]
Remove open-coded Vector in unicsv. Make better use of QString internally.
robertlipe [Sun, 15 Sep 2013 06:15:22 +0000 (06:15 +0000)]
Commit 'ptesto', a script for running valgrinds in parallel. Really crude,
but still kind of handy.
robertlipe [Sun, 15 Sep 2013 05:50:21 +0000 (05:50 +0000)]
Correct leak in bcr that I just introduced when I partially rolled back a failed experiment in making S1 and S2 into QStrings.
robertlipe [Sun, 15 Sep 2013 05:41:21 +0000 (05:41 +0000)]
A bulky, but rather brainless pass at treating the important strings in
struct waypoint as a class instead of C string. Of course, that struct
has one member - a C string - but this starts to hightlight the places
that are going to be problem areas for us.
With NEW_STRINGS turned on, we basically run, but suffer from a double
encoding of non-ascii strings. Every format seems to be affected, so
it's probably in CET somewhere. This isn't a QString thing in any obvious
way, as the underlying data types are still actually C Strings.
From here, additional passes can be made, either turning the individual
string pointer conversions off and whacking on a few files at a time or
going full money and making String a QString.
It does highlight the need for better vararg-style functions like warning,
fatal, and our debugging printfs to to know about stream operators.
robertlipe [Sat, 14 Sep 2013 23:49:03 +0000 (23:49 +0000)]
Fixes for optionsdlg: only use ranges when we HAVE ranges (and they're not equal). Let help link directly to the correct page.
Whitespace cleanup.
tsteven4 [Fri, 13 Sep 2013 20:26:47 +0000 (20:26 +0000)]
catch a straggler up with qt include renaming.
tsteven4 [Thu, 12 Sep 2013 22:14:07 +0000 (22:14 +0000)]
add xmlstreamwriter methods analogous to QXmlStreamWriter that strip illegal characters.
tsteven4 [Thu, 12 Sep 2013 02:52:40 +0000 (02:52 +0000)]
Get the gui ready for Qt5 while maintaining support for Qt4.
tsteven4 [Thu, 12 Sep 2013 02:45:53 +0000 (02:45 +0000)]
catch gui translation files up with recent source renaming and UpgradeCheck class work.
robertlipe [Wed, 11 Sep 2013 08:42:06 +0000 (08:42 +0000)]
Minor internal changes to make new_strings land better.
robertlipe [Wed, 11 Sep 2013 07:46:08 +0000 (07:46 +0000)]
Fix mem leak I introduced earlier tonight (this morning?) in ozi.
robertlipe [Wed, 11 Sep 2013 05:06:34 +0000 (05:06 +0000)]
Pull out a little more char* from our core infrastructure. Add shims to turn down case_ignore_strmp and case_ignore_strncmp().
Tweak reference files to deal with more correct(?) ordering in edge cases.
Start sketching a shim layer for shortname, description, and text, but increasingly I'm of the opinion that our only options are either do it all in one submit (eeek!) or to add additional members of struct waypt that are allocated/copied at waypt_add time so we can then at least separate readers and writers. Instinct tells me the latter will result in harsh punishment as we'll have members that are out of sync and it will be difficult to flush them out. So substantial parts of this CL may get tossed.
robertlipe [Wed, 11 Sep 2013 01:17:05 +0000 (01:17 +0000)]
Steve replaces use of deprecated QHttp with QNetworkAccessManager.
robertlipe [Tue, 10 Sep 2013 16:59:53 +0000 (16:59 +0000)]
Peter Popovec tweaks gtrnctr to fix sometimes missing lap info on write.
robertlipe [Mon, 9 Sep 2013 17:30:01 +0000 (17:30 +0000)]
Remove explicit xstrdup(CSTR... in favor of helper.
robertlipe [Mon, 9 Sep 2013 01:38:37 +0000 (01:38 +0000)]
Style Cleanup from last commit.
robertlipe [Mon, 9 Sep 2013 01:37:51 +0000 (01:37 +0000)]
Dirk Stitchling adds support for Navin/ZNEX miniHomer 2.8 with 10Hz time.
robertlipe [Sat, 7 Sep 2013 07:38:00 +0000 (07:38 +0000)]
Fix (probably) memory leak in xmltag converion.
robertlipe [Fri, 6 Sep 2013 20:38:11 +0000 (20:38 +0000)]
Move remaining char*'s in xmltag to QStrings. Tweak various callers and
copy ctors. vtesto on CentOS 6.4 seems no worse for the wear.
robertlipe [Fri, 6 Sep 2013 19:54:37 +0000 (19:54 +0000)]
Remove some read-only struct members in xml_tag. Passes vtesto.
robertlipe [Fri, 6 Sep 2013 19:40:51 +0000 (19:40 +0000)]
Fix another new/xfree mismatch.
robertlipe [Fri, 6 Sep 2013 19:27:03 +0000 (19:27 +0000)]
Correct allocation in xml_tag pseudo copy constructor.
robertlipe [Fri, 6 Sep 2013 19:15:28 +0000 (19:15 +0000)]
A very conservative move of xml_tag into a class of its own with
headers of its own. Tweak xmalloc/xfree to new/delete. Regenerate deps.
tsteven4 [Wed, 4 Sep 2013 00:19:06 +0000 (00:19 +0000)]
fix waypoint counting errors in tpo and igc readers.
add a filter to check the counts against the lists.
tsteven4 [Mon, 2 Sep 2013 13:02:46 +0000 (13:02 +0000)]
fix memory leaks in cup, easygps, mapsend, osm, pcx and skyforce exposed by test-all, valgrind and patience.
tsteven4 [Sun, 1 Sep 2013 18:46:42 +0000 (18:46 +0000)]
fix issue with naviguide reader double counting route waypts.
tsteven4 [Sun, 1 Sep 2013 17:23:02 +0000 (17:23 +0000)]
fix bug in garmin_txt reader that could result in uninitialised value(s) being used when the input does not contain "Date Modified" data.
tsteven4 [Sun, 1 Sep 2013 14:29:29 +0000 (14:29 +0000)]
fix iblue styles, writing was causing usage of uninitialised byte(s).
fix iblue style prologue to match written fields, text taken from 2010-09-13 email.
modify mkstyle.sh to produce code compatible with our astylerc options.
tsteven4 [Sun, 1 Sep 2013 13:19:35 +0000 (13:19 +0000)]
improve support for testo running from alternate directories.
tsteven4 [Sat, 31 Aug 2013 00:09:51 +0000 (00:09 +0000)]
add option to capture valgrind output in a log file.
tsteven4 [Fri, 30 Aug 2013 21:25:48 +0000 (21:25 +0000)]
fix some url related memory leaks.
add constructor for UrlLink from char*.